Bug #514

Popups richtext fix

Added by Przemys?aw Maci?g 1714 days ago. Updated 345 days ago.

Status:New Start:
Priority:Normal Due date:
Assigned to:- % Done:

0%

Category:UserInterface
Target version:0.14
Operating System:

All

Reported in:

0.11-devel


Description

I created a patch to fix some weird behaviours of popups messages. Just truncating a popup message text can cause situations like this:
  • text will be trancated 'inside' icon tag
  • text will be trancated 'inside' a tag
    both situations will give a bad string to show. Patch add a simple
    function to correct this situations (and similar ones).

For future use : when porting to qt4 latin1() function (like here)
c = intext.at(i).latin1();

has to be changed to
c = intext.at(i).toLatin1();

I add this function to common.cpp for future use with (ex.) status showing in roster (I hope someday it will be in roster ;) ).

Regards,
Przemek

psi-fix_popup_richtext.patch (3.1 KB) Przemys?aw Maci?g, 20 Nov 2005 03:49 PM

psi-fix_popup_richtext.patch (3.8 KB) Przemys?aw Maci?g, 23 Nov 2005 12:49 PM


Related issues

blocks Bug #764 Patch review (META TASK) New

History

Updated by Przemys?aw Maci?g 1714 days ago

psi-fix_popup_richtext.patch

Updated by Przemys?aw Maci?g 1711 days ago

psi-fix_popup_richtext.patch - new version

Updated by Przemys?aw Maci?g 1711 days ago

second patch version:
- maximum visible characters are now 200
- 'a' tag is not being counted as visible (only letters 'inside' the tag)
- check to see is truncating needed and (if so) add "..." to the end
of a message - different than original one, since now texts can have
different length
- no more latin1 characters conversion

Updated by Kevin Smith 1031 days ago

I don't remember if this is fixed yet, check for 0.12.

Updated by Justin Karneges 345 days ago

  • Target version set to 0.14

Also available in: Atom PDF